[for minor release] feat: remove the python2 pilot starter#8339
Open
fstagni wants to merge 1 commit intoDIRACGrid:integrationfrom
Open
[for minor release] feat: remove the python2 pilot starter#8339fstagni wants to merge 1 commit intoDIRACGrid:integrationfrom
fstagni wants to merge 1 commit intoDIRACGrid:integrationfrom
Conversation
fstagni
force-pushed
the
remove_py2_pilot
branch
2 times, most recently
from
79fa9de to
d4bfc37
Compare
fstagni
changed the title
fstagni
changed the title
chrisburr
reviewed
Oct 23, 2025
1 task
aldbr
reviewed
Feb 19, 2026
fstagni
force-pushed
the
remove_py2_pilot
branch
from
d4bfc37 to
c400de5
Compare
fstagni
force-pushed
the
remove_py2_pilot
branch
from
c400de5 to
f177e91
Compare
fstagni
changed the title
Contributor
Author
|
This PR is ready. Given that Pilot removed the support for Python2 at the beginning of this week, and no complains were received, I assume this is ready to be merged. |
aldbr
requested changes
Apr 7, 2026
Comment on lines
67
to
70
| try: | ||
| from cStringIO import StringIO | ||
| except ImportError: | ||
| from io import StringIO |
Contributor
There was a problem hiding this comment.
cStringIO does not exist in python3 (https://docs.python.org/3.3/whatsnew/3.0.html?highlight=cstringio):
The StringIO and cStringIO modules are gone. Instead, import the io module and use io.StringIO or io.BytesIO for text and data respectively.
Suggested change
| from io import StringIO |
| # if we get here we break out of the loop of locations | ||
| break | ||
| except (url_library_URLError, Exception) as e: | ||
| except (URLError, Exception) as e: |
Contributor
There was a problem hiding this comment.
I guess the URLError is redundant here no?
Suggested change
| except (URLError, Exception) as e: | |
| except Exception as e: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the spirit of DIRACGrid/Pilot#266. This one is optional.
If this one is merged, it fully halts all python2 support for pilots. So, we can wait longer before merging.
BEGINRELEASENOTES
*WMS
NEW: remove support for python2 pilots
ENDRELEASENOTES